✨ feat(k8sgpt-rbac.yaml): add new RBAC configuration for k8sgpt operator #274

MateSousa · 2023-11-25T01:45:38Z

Closes #259

📑 Description

Migrate all RBAC related resources to Helm chart's templates

✅ Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

ℹ Additional Information

chart/operator/templates/k8sgpt-rbac.yaml

arbreezy · 2023-11-26T21:36:12Z

@MateSousa you want also to remove the permissions of the operator's cluster role cause operator won't manage anymore the k8sgpt's role creation right?

The new RBAC configuration file is added to define the permissions for the k8sgpt operator. This includes a ClusterRole, a ClusterRoleBinding, and a ServiceAccount. The ClusterRole defines the permissions that the operator has, such as creating, listing, getting, watching, and deleting resources. The ClusterRoleBinding binds the ClusterRole to the ServiceAccount, which represents the operator in the Kubernetes cluster. This setup ensures that the operator has the necessary permissions to function correctly, improving the security and functionality of the application. Signed-off-by: MateSousa <[email protected]>

… role binding functions The service account, cluster role, and cluster role binding functions were removed from the k8sgpt.go file. These functions were creating a service account, cluster role, and cluster role binding for K8sGPT, but they are no longer needed. Signed-off-by: MateSousa <[email protected]>

Signed-off-by: MateSousa <[email protected]>

…oleBinding configuration The new ClusterRoleBinding configuration file is added to manage permissions for the service account "k8sgpt". This change allows the service account to have the necessary permissions to perform its tasks within the specified namespace, improving the security and management of the Kubernetes cluster. Signed-off-by: MateSousa <[email protected]>

…h extensive permissions A new Kubernetes cluster role has been added to provide extensive permissions for the application. This role includes permissions to create, list, get, watch, and delete resources across all API groups. This is necessary to ensure that the application has the necessary permissions to interact with the Kubernetes API and manage resources effectively. Signed-off-by: MateSousa <[email protected]>

Signed-off-by: MateSousa <[email protected]>

The new ServiceAccount 'k8sgpt' is created to provide identity for processes that run in a Pod. This is crucial for the k8sgpt-operator to interact with Kubernetes APIs. The ServiceAccount is labeled with metadata to indicate its component, creator, and the part of the application it belongs to, which aids in better resource management and tracking. Signed-off-by: MateSousa <[email protected]>

Signed-off-by: MateSousa <[email protected]>

MateSousa · 2023-11-30T00:37:27Z

@MateSousa you want also to remove the permissions of the operator's cluster role cause operator won't manage anymore the k8sgpt's role creation right?

@arbreezy you're right, i just removed

arbreezy · 2024-03-28T00:57:27Z

Apologies @MateSousa , I forgot that we didn't merge this PR; overall looks good !

can you please resolve the conflicts and I will test a bit more before we merge it

Signed-off-by: Matheus Sousa <[email protected]>

MateSousa · 2024-03-29T21:21:10Z

@arbreezy done

arbreezy

@MateSousa , I think you override an existing functionality here.

arbreezy · 2024-03-30T00:11:51Z

pkg/resources/k8sgpt.go

-	objs = append(objs, svc)
-
-	deployment, er := GetDeployment(config, outOfClusterMode, c)
+	deployment, er := GetDeployment(config)


arbreezy · 2024-04-11T16:04:57Z

Hey @MateSousa I am happy to properly resolve the previous conflicts and get this merged.

MateSousa · 2024-04-12T11:32:58Z

Hey @arbreezy, sorry for delay, I was sick... I'm going to fix that today.

arbreezy · 2024-04-15T20:14:59Z

Hey @arbreezy, sorry for delay, I was sick... I'm going to fix that today.

@MateSousa hope you are feeling better !

arbreezy · 2024-04-23T20:14:08Z

@MateSousa, happy to help with this PR if you don't have time, it's almost ready to be merged

Signed-off-by: Matheus Sousa <[email protected]>

…v0.16.0 (k8sgpt-ai#396) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

Signed-off-by: Aaron Miller <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

Signed-off-by: Alex Jones <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

…#401) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

This commit adds `google` to the list of supported AI backends. Fixes: k8sgpt-ai#347 Signed-off-by: VaibhavMalik4187 <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

…#409) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

…ffers/go to v1.33.0-20240406062209-1cc152efbf5c.1 (k8sgpt-ai#405) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

… v1.3.0-20240406062209-1cc152efbf5c.2 (k8sgpt-ai#404) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

Now, the result crd will be generated in the target namespace instead of k8sgpt config namespace. Addresses: k8sgpt-ai#390 Signed-off-by: VaibhavMalik4187 <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

…-ai#416) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

This commit bumps the `controller-gen` and `controller-tools` version in the helm charts, make file to `v0.14.0` This gets rid of version specific errors caused due to the `sigs.k8s.io/controller-tools/cmd/[email protected]` package. Signed-off-by: VaibhavMalik4187 <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.21.0 to 0.23.0. - [Commits](golang/net@v0.21.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

…gpt-ai#408) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Jones <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

…#417) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

* fix: change deployment image reconciling Signed-off-by: ultram4rine <[email protected]> * improve image reconciling Signed-off-by: ultram4rine <[email protected]> --------- Signed-off-by: ultram4rine <[email protected]> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

…#427) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

…-ai#423) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Aris Boutselis <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

There was a misplaced details block causing the Bedrock section not to function as expected. Signed-off-by: Rob Heckel <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

…ffers/go to v1.34.0-20240406062209-1cc152efbf5c.1 (k8sgpt-ai#432) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

Signed-off-by: Matheus Sousa <[email protected]>

MateSousa · 2024-05-02T01:45:54Z

@arbreezy hey, it looks like I made a huge mess, I'm going to create a new PR, sorry :(

MateSousa requested review from a team as code owners November 25, 2023 01:45

MateSousa force-pushed the feat-migrate-all-rbac-to-helm-chart-template branch from c10bae6 to 6f8189f Compare November 25, 2023 01:46

arbreezy requested changes Nov 26, 2023

View reviewed changes

chart/operator/templates/k8sgpt-rbac.yaml Outdated Show resolved Hide resolved

chart/operator/templates/k8sgpt-rbac.yaml Outdated Show resolved Hide resolved

chart/operator/templates/k8sgpt-rbac.yaml Outdated Show resolved Hide resolved

MateSousa added 8 commits November 29, 2023 21:36

🐛 fix(k8sgpt-rbac.yaml): correct indentation error

7b5ed19

Signed-off-by: MateSousa <[email protected]>

🔥 remove(k8sgpt-rbac.yaml): split resources between files.

89248c1

Signed-off-by: MateSousa <[email protected]>

🔥 remove(manager-rbac.yaml): remove permissions for apiextensions.k8s.io

dcafac4

Signed-off-by: MateSousa <[email protected]>

MateSousa force-pushed the feat-migrate-all-rbac-to-helm-chart-template branch from 2b3e62b to dcafac4 Compare November 30, 2023 00:37

MateSousa requested a review from arbreezy November 30, 2023 00:37

Merge branch 'main' into feat-migrate-all-rbac-to-helm-chart-template

6d79177

Signed-off-by: Matheus Sousa <[email protected]>

Merge branch 'main' into feat-migrate-all-rbac-to-helm-chart-template

271a2e1

arbreezy requested changes Mar 30, 2024

View reviewed changes

arbreezy reviewed Mar 30, 2024

View reviewed changes

arbreezy mentioned this pull request Apr 19, 2024

[Feature]: For running on AWS, add IAM Roles for service accounts (IRSA) support #398

Closed

2 tasks

MateSousa and others added 2 commits May 1, 2024 22:43

fix: fixed conflict mistake

a1d919d

Signed-off-by: Matheus Sousa <[email protected]>

aaroniscode and others added 25 commits May 1, 2024 22:43

fix Amazon Bedrock instructions in README (k8sgpt-ai#397)

21aa48d

Signed-off-by: Aaron Miller <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

bug: fixing missing details (k8sgpt-ai#402)

3b4795f

Signed-off-by: Alex Jones <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

chore: small update to fix linter (k8sgpt-ai#403)

ffcf3ae

Signed-off-by: Alex Jones <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

chore(main): release 0.1.3 (k8sgpt-ai#392)

3d67b9f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

[feature]: add gemini to supported AI backends (k8sgpt-ai#406)

0c81761

This commit adds `google` to the list of supported AI backends. Fixes: k8sgpt-ai#347 Signed-off-by: VaibhavMalik4187 <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

chore(deps): update azure/setup-helm digest to fe7b79c (k8sgpt-ai#413)

d005325

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

chore(deps): update helm/kind-action action to v1.10.0 (k8sgpt-ai#424)

fa84906

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

fix(deps): update k8s.io/utils digest to 0849a56 (k8sgpt-ai#425)

8c48826

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

chore(deps): update actions/checkout digest to 0ad4b8f (k8sgpt-ai#422)

19dc780

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Matheus Sousa <[email protected]>

Update README.md (k8sgpt-ai#429)

b5c6fc1

There was a misplaced details block causing the Bedrock section not to function as expected. Signed-off-by: Rob Heckel <[email protected]> Signed-off-by: Matheus Sousa <[email protected]>

chore: removed old logic

acb8011

Signed-off-by: Matheus Sousa <[email protected]>

MateSousa force-pushed the feat-migrate-all-rbac-to-helm-chart-template branch from 8d30956 to acb8011 Compare May 2, 2024 01:43

MateSousa closed this May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ feat(k8sgpt-rbac.yaml): add new RBAC configuration for k8sgpt operator #274

✨ feat(k8sgpt-rbac.yaml): add new RBAC configuration for k8sgpt operator #274

MateSousa commented Nov 25, 2023

arbreezy commented Nov 26, 2023

MateSousa commented Nov 30, 2023

arbreezy commented Mar 28, 2024

MateSousa commented Mar 29, 2024

arbreezy left a comment •

edited

Loading

arbreezy Mar 30, 2024

arbreezy commented Apr 11, 2024

MateSousa commented Apr 12, 2024

arbreezy commented Apr 15, 2024

arbreezy commented Apr 23, 2024

MateSousa commented May 2, 2024

✨ feat(k8sgpt-rbac.yaml): add new RBAC configuration for k8sgpt operator #274

✨ feat(k8sgpt-rbac.yaml): add new RBAC configuration for k8sgpt operator #274

Conversation

MateSousa commented Nov 25, 2023

📑 Description

✅ Checks

ℹ Additional Information

arbreezy commented Nov 26, 2023

MateSousa commented Nov 30, 2023

arbreezy commented Mar 28, 2024

MateSousa commented Mar 29, 2024

arbreezy left a comment • edited Loading

Choose a reason for hiding this comment

arbreezy Mar 30, 2024

Choose a reason for hiding this comment

arbreezy commented Apr 11, 2024

MateSousa commented Apr 12, 2024

arbreezy commented Apr 15, 2024

arbreezy commented Apr 23, 2024

MateSousa commented May 2, 2024

arbreezy left a comment •

edited

Loading